Opened 15 years ago

Closed 15 years ago

#32 closed defect (fixed)

Clean up the cumbersome EjectPod code

Reported by: MrWabbit Owned by: MrWabbit
Priority: minor Milestone: 1.80
Component: Core Version: 1.77
Keywords: EjectPod, EjectPodPane, EjectPodPaneImage Cc:

Description (last modified by Henrik Heimbuerger)

EjectPod is constructed as a pane, which makes it inflexible when switching HUDs. (SwitchPane doesn't have a 'default' option, so you have to enumerate every possible value).

It is then converted to an image, for some reason, before being added to the dialogs. It doesn't make sense and is annoying for HUDsmiths.

I wonder who the brave soul will be that shall provide a fix for this?

Change History (10)

comment:1 Changed 15 years ago by SVN

New commit by bunnywabbit (revision [109]):
[fix for ticket #32] EjectPod? display now constructed as an Image. Added some headers for easy reference.

comment:2 Changed 15 years ago by MrWabbit

Status: new → accepted

comment:3 Changed 15 years ago by Henrik Heimbuerger

Description: modified (diff)
Summary: EjectPod code cumbersome and weird → Clean up the combersome EjectPod code

comment:4 Changed 15 years ago by Henrik Heimbuerger

Description: modified (diff)
Summary: Clean up the combersome EjectPod code → Clean up the cumbersome EjectPod code

comment:5 Changed 15 years ago by Henrik Heimbuerger

Owner: changed from MrWabbit to Bunnywabbit
Status: accepted → assigned

comment:6 Changed 15 years ago by Henrik Heimbuerger

Shall we defer this to 2.0?

comment:7 Changed 15 years ago by Henrik Heimbuerger

Priority: minor → trivial

comment:8 Changed 15 years ago by MrWabbit

Priority: trivial → minor

Well it's already done, and GlassHUD needs it to be an image, because SwitchImage? is more flexible than SwitchPane?. (SwitchImage? allows a default option, while SwitchPane? requires each possible value to be enumerated).

comment:9 Changed 15 years ago by MrWabbit

Owner: changed from Bunnywabbit to MrWabbit
Status: assigned → accepted

comment:10 Changed 15 years ago by MrWabbit

Resolution: → fixed
Status: accepted → closed
Note: See TracTickets for help on using tickets.