Opened 17 years ago

Closed 16 years ago

#17 closed defect (fixed)

JelloShot issues with transparency.

Reported by: bp Owned by: MrWabbit
Priority: minor Milestone: 1.77
Component: HUD: JelloShot Version: 1.76
Keywords: jelloshot, transparency, glitch Cc:

Description (last modified by MrWabbit)

From the CortUI 1.75 release notes:

JelloShot has issues with transparency. I'll look into it.

Attachments (2)

dialog.mdl (127.7 KB) - added by MrWabbit 17 years ago.
dialog.mdl.ticket17.against_r74.patch (13.0 KB) - added by Henrik Heimbuerger 16 years ago.
patch of the attached dialog.mdl against r74 (the revision dialog.mdl was at at the time)

Download all attachments as: .zip

Change History (14)

comment:1 Changed 17 years ago by Henrik Heimbuerger

Description: modified (diff)
Keywords: jelloshot transparency glitch added

comment:2 Changed 17 years ago by bp

Version: dev1.76

Adding version information.

comment:3 Changed 17 years ago by MrWabbit

Resolution: fixed
Status: newclosed

I think i took care of most of jelloshots and lesshuds transparency problems.

Ugly kludge, though.

I used the gauge image rect function to make non-gauge images transparent, similar to Myotis' solution to bugfix #6 in release 1.76.

Only i did it to all remaining images.

Changed 17 years ago by MrWabbit

Attachment: dialog.mdl added

comment:4 Changed 17 years ago by Henrik Heimbuerger

Resolution: fixed
Status: closedreopened

Reopening, as there's no commit.

comment:5 Changed 16 years ago by Henrik Heimbuerger

Milestone: 1.77

Changed 16 years ago by Henrik Heimbuerger

patch of the attached dialog.mdl against r74 (the revision dialog.mdl was at at the time)

comment:6 Changed 16 years ago by Henrik Heimbuerger

Owner: changed from FlingPu to Henrik Heimbuerger
Status: reopenedaccepted

comment:7 Changed 16 years ago by Henrik Heimbuerger

Resolution: worksforme
Status: acceptedclosed

Can't reproduce this in R5. Please reopen with description and/or screenshots if you can still reproduce this.

BW's patch has *not* been applied.

comment:8 Changed 16 years ago by MrWabbit

Description: modified (diff)

these are the suggested code changes for this workaround:

for lessHUD (ca line 2879):

// fpTargetOvalColor =
//         BlendImage(
//            ImportImageFromFile("mods/CortUI/media/cortui_fp1_target_oval_color.png", true),
//            hudBlendMode
//    );

fpTargetOvalColor =
	BlendImage(
		GaugeImageRect(
			JustifyBottom,
			ImportImageFromFile("mods/CortUI/media/cortui_fp1_target_oval_color.png", true),
			Rect(0, 0, 164, 67),
			true,
			1
		),
		hudBlendMode
	);

for JelloShot? (ca line 1972):

//fp2TargetOvalColor = BlendImage(
//	ImportImageFromFile("mods/CortUI/media/cortui_fp2_target_oval_color.png", true),
//	hudBlendMode
//);

fp2TargetOvalColor =
	BlendImage(
		GaugeImageRect(
			JustifyBottom,
			ImportImageFromFile("mods/CortUI/media/cortui_fp2_target_oval_color.png", true),
			Rect(0, 0, 256, 256),
			true,
			1
		),
		hudBlendMode
	);

before:

http://opiumvoorhetvolk.dyndns.org/stuff/misc/BW/JelloShot_Before.png
http://opiumvoorhetvolk.dyndns.org/stuff/misc/BW/lessHud_before.png

after:
jelloshot:
http://opiumvoorhetvolk.dyndns.org/stuff/misc/BW/jelloshot_after.png
Lesshud out of range:
http://opiumvoorhetvolk.dyndns.org/stuff/misc/BW/lessHud_after.png
Lesshud Inrange:
http://opiumvoorhetvolk.dyndns.org/stuff/misc/BW/lessHUD_after_inrange.png

comment:9 Changed 16 years ago by MrWabbit

Resolution: worksforme
Status: closedreopened

comment:10 Changed 16 years ago by SVN

New commit by cort (revision [89]):
[Fix for ticket #17] Applied the changes as listed by Bunnywabbit in comment:8:ticket:17. This should fix various transparency problems in lessHUD and JelloShot.

comment:11 Changed 16 years ago by Henrik Heimbuerger

Owner: changed from Henrik Heimbuerger to MrWabbit
Status: reopenedassigned

Please test again and close as fixed or reassign back to me.

comment:12 Changed 16 years ago by MrWabbit

Resolution: fixed
Status: assignedclosed

tested with installer 1.77-dev-r92. both jelloShot and LessHud? targetviews are now properly translucent.

Note: See TracTickets for help on using tickets.